fix: AC/DC charge limit settings not working on newer Gen3 vehicles - #983
fix: AC/DC charge limit settings not working on newer Gen3 vehicles#983killerbee84 wants to merge 5 commits into
Conversation
| enabled: bool = True | ||
|
|
||
| # Generation type (e.g. "G3") | ||
| gen_type: str = None |
There was a problem hiding this comment.
Lets use generation two fields up for this.
cdnninja
left a comment
There was a problem hiding this comment.
Looks like pre-commits are failing.
|
I can't fix the pre-commit issue. The API path is "v2/ev/reserv/socset" and pre-commit is complaining about the "reserv". |
|
I think you can exempt it from code spell. If we merge as is it will fail forever so needs fixing. I also updated the branch, test snapshots need to be updated. |
|
Some of this was actually my recent PR by pytest snapshot update isn't working...ugh. |
I wanted to follow up if you could fix codespell? If interested in having this merged still. |
|
I looked at this PR and see a few issues that need resolving before it can merge:
Happy to pick this up and implement it properly if someone can provide a CA API vehicle list response confirming the |
|
@killerbee84 any update on this? |
This fixes the AC and DC charge limit settings on Gen3 vehicles like the IONIQ 9.
Currently, changing the limits inside HA does not work.