allow for signing multiple callsign domains and private keys#66
Open
bikehara-ias wants to merge 13 commits into
Open
allow for signing multiple callsign domains and private keys#66bikehara-ias wants to merge 13 commits into
bikehara-ias wants to merge 13 commits into
Conversation
bikehara-ias
force-pushed
the
reseller
branch
from
February 16, 2022 04:26
f617407 to
f951497
Compare
cmlight
requested changes
Feb 16, 2022
cmlight
left a comment
cmlight
left a comment
Contributor
There was a problem hiding this comment.
It looks like the logging-related function signature change partially bleeds into this PR, so I am not sure it is mergeable in this state.
cmlight
approved these changes
Feb 16, 2022
Contributor
Author
|
yes, they are built off of each other. once the other PRs are merged, this PR will be all good. |
bikehara-ias
marked this pull request as draft
February 17, 2022 19:22
bikehara-ias
marked this pull request as ready for review
March 2, 2022 00:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.