Emit absolute creative rewrite URLs#917
Draft
ChristianPavilonis wants to merge 1 commit into
Draft
Conversation
ChristianPavilonis
marked this pull request as draft
July 16, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publisher.public_origin(with the legacyhttps://{publisher.domain}fallback) and emit absolute first-party URLs for creative proxy/click rewrites, creative TSJS, sign responses, rebuild responses, and auctionadm.Changes
crates/trusted-server-core/src/settings.rspublisher.public_origin.crates/trusted-server-core/src/{creative,proxy}.rscrates/trusted-server-js/lib/src/integrations/creative//first-party/proxy-rebuildconsistently.docs/, example config, and changelog#907remains independent: this change preserves the current TSJS module-set source/hash selection and qualifies only the selected creative script source.#916remains independent: this branch is based directly onmainand does not change optional-rewrite behavior.Closes
Closes #915
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serveChecklist
unwrap()in production code — useexpect("should ...")tracingmacros (notprintln!) — no logging was added; this repository useslogmacros.