fix issue #327#328
Merged
Merged
Conversation
kujaku11
self-requested a review
March 20, 2026 21:10
kujaku11
approved these changes
Mar 20, 2026
kujaku11
left a comment
kujaku11
left a comment
Collaborator
There was a problem hiding this comment.
Looks like a reasonable solution with suggestions for updated down later.
Collaborator
There was a problem hiding this comment.
Looks like a reasonable fix with todos for future work
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## patches #328 +/- ##
===========================================
- Coverage 81.82% 81.30% -0.53%
===========================================
Files 223 232 +9
Lines 46520 47922 +1402
===========================================
+ Hits 38066 38964 +898
- Misses 8454 8958 +504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #327