Fix phoenix filter handling#330
Merged
Merged
Conversation
Generate changelog for unreleased changes with specific tag.
Add a new workflow (.github/workflows/bump-version.yml) that bumps the package version, generates changelog/HISTORY.rst, and commits changes when a release label (release:major/minor/patch) is added to an open PR. Simplify .github/workflows/publish.yml to only run publish steps on PR close/merge, remove the prior in-publish version-bump/update job, and keep a single publish job that creates a GitHub Release and uploads to TestPyPI then PyPI. Also update the bump-my-version call to use `show current_version` and make minor permission/formatting adjustments.
Add a new example notebook (docs/examples/notebooks/new_documentation.ipynb) and update PhoenixClient to gracefully handle None inputs for receiver and calibration paths. The client now explicitly skips processing when value is None (avoiding unintended TypeError/ValueError), and includes a minor formatting cleanup for sensor calibration dict assignment.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 81.12% 81.13%
=======================================
Files 232 232
Lines 47934 47966 +32
=======================================
+ Hits 38887 38916 +29
- Misses 9047 9050 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated how filters are being handled for Phoenix MTU-5C files and workflow.
channel_responseandchannel_metadata.filtersshould be similar.