Prevent deletion of last user from a reporting organisation#72
Merged
Prevent deletion of last user from a reporting organisation#72
Conversation
simon-20
changed the title
chrisarridge
approved these changes
Mar 24, 2026
This refactor removes the unused context parameter from the assert_precondition_met function, decoupling this utility function from the app context object.
This refactoring removes from the RYDUserException class the dependency on the UserAndCredentials object, making it depend only on the fields it uses, which should facilitate easier testing.
This refactoring removes from the assert_precondition_met function dependence on the UserAndCredentials object, making it depend only on the fields it uses, which should facilitate easier testing
simon-20
force-pushed
the
sk-fix-prevent-delete-removing-all-users
branch
from
33e5b86 to
6c86f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
assert_precondition_metfunction and theRYDUserExceptionclass, removing their dependencies on rich context objects, and making them depend only on primitive values they require - this should make it easier to test.NOTE: this PR is setup as a compare against the
sk-search-discoverable-orgsbranch - the pre-existing PR for that branch (#70) should be merged and this branch rebased onto develop before merging this.This should close issues #47 and #71.