update API version URL as previous link was not working#3485
Open
MohishKhadse55 wants to merge 1 commit intoIBM:mainfrom
Open
update API version URL as previous link was not working#3485MohishKhadse55 wants to merge 1 commit intoIBM:mainfrom
MohishKhadse55 wants to merge 1 commit intoIBM:mainfrom
Conversation
Signed-off-by: Mohish <mohish@Mohishs-MacBook-Pro.local>
Member
Author
|
Wondering why changing comment is failing in this tests |
hindessm
reviewed
Mar 29, 2026
Collaborator
hindessm
left a comment
hindessm
left a comment
There was a problem hiding this comment.
I re-ran the failing tests and they passed.
The new URL seems like a good choice to me. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the Sarama library to understand its structure and behavior,
I noticed that the referenced URL (https://kafka.apache.org/26/protocol.html#api_versions) was no longer working (returns 404), indicating it may be deprecated or archived. I compared it with the updated documentation and replaced it with ( https://kafka.apache.org/42/design/protocol/#retrieving-supported-api-versions) .
Please let me know if this aligns with the requirements.