Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
+ Coverage 73.81% 73.86% +0.04%
==========================================
Files 419 420 +1
Lines 66225 66380 +155
Branches 11122 11149 +27
==========================================
+ Hits 48886 49030 +144
- Misses 14798 14805 +7
- Partials 2541 2545 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@CopyDemon if you get a chance could you look at this and approve? It's an added utility not used inside core, at the moment, so should "do no harm" as long as it builds (which you can see it does). |
CopyDemon
approved these changes
Apr 8, 2026
Contributor
CopyDemon
left a comment
There was a problem hiding this comment.
I think this is good to merge—it doesn’t affect the core and all tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1755
Summary/Motivation:
List of JSON documents, with accompanying index with some metadata and offset of each document in the file.
This is motivated by the need to keep a history of report objects, or the results of a parameter sweep, or both, from the
idaes.core.util.structfs.FlowsheetRunner. These may be rather large, so the implementation keeps the offsets of each JSON document in a separate file, allowing O(1) access to a given document without parsing or reading any other document's data.Changes proposed in this PR:
JsonListclassLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: