Restore workaround for MPS-34340 in variability "for-all-variants" extension#1738
Open
kbirken wants to merge 4 commits intomaintenance/mps20251from
Open
Conversation
… commit db21d97 in 2024-12 (#1709).
kbirken
requested review from
dbinkele
and removed request for
arimer and
jonaskraemer
…re/variability_forallvariants_restore_workaround_1709
dbinkele
previously approved these changes
Apr 13, 2026
…re/variability_forallvariants_restore_workaround_1709 # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the workaround in the "for-all-variants" runtime needed for MPS-34340. In mps20241, this problem was hidden because exceptions in checking rules were not reported, and so the removal of the workaround didn't cause any visible issues. In mps20251, exception are thoroughly handled, so the workaround is needed again.
Notes:
org.iets3.variability.artifacts.typesystem.runtimewhich hosts the workaround has been moved from IETS3.Core to IETS3.Opensource in 2025. So the workaround could not be just restored, but had to be re-added by copy&paste.TwoActualRoots), which checks that the workaround is working correctly. This test needs stuff from IETS3.Core, so it could not be migrated to IETS3.Opensource together with theorg.iets3.variability.artifacts.typesystem.runtimesolution. Thus, we need a companion PR in IETS3.Core to adapt the test.This solves #1709.