Add external source fields in event #2760
Draft
sudip-khanal wants to merge 1 commit into
Draft
Conversation
…m field report - Added auto_generated_external_source field to Event - Added auto_generated_external_source_id field to Event - Set both fields during automatic event creation from a FieldReport
sudip-khanal
force-pushed
the
feat/update-event-creation-logic-from-field-report
branch
from
8643590 to
d6b5ff6
Compare
susilnem
requested changes
Jun 10, 2026
| help_text=_("External source or system from which the original event data originated."), | ||
| ) | ||
| # Identifier of the originating event record in the external system | ||
| auto_generated_external_source_id = models.CharField( |
Member
There was a problem hiding this comment.
Any reason for using CharField here?
This looks like it should be a UUID field.
If this value is always expected to be a UUID, would it be possible to use a UUIDField instead? That would provide built-in validation.
Contributor
Author
There was a problem hiding this comment.
In the MRCS site, we are not using UUIDs for the id field. If it’s coming externally as a UUID, we can switch to a UUIDField. @frozenhelium can you also confirm this?
| ) | ||
|
|
||
| # External system or source from which the event data originated | ||
| auto_generated_external_source = models.CharField( |
Member
There was a problem hiding this comment.
Do we even need these fields here in the event table? Do we need filtering for this features?
Contributor
Author
There was a problem hiding this comment.
Yes, we may need these for filtering in the future. @frozenhelium , can you also confirm this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
auto_generated_external_sourcefield to Eventauto_generated_external_source_idfield to Eventexternal_sourcefield to FieldReportexternal_source_idfield to FieldReportChecklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.