Skip to content

Feat: optimise active dref query#2762

Merged
szabozoltan69 merged 1 commit into
developfrom
feature/optimise-active-dref
Jun 11, 2026
Merged

Feat: optimise active dref query#2762
szabozoltan69 merged 1 commit into
developfrom
feature/optimise-active-dref

Conversation

@susilnem

@susilnem susilnem commented Jun 11, 2026

Copy link
Copy Markdown
Member

Changes

  • Remove n+1 query
  • Use annotate on active dref query
  • Refactor serializer changes

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@szabozoltan69

Copy link
Copy Markdown
Contributor

Thanks for this fix, dear @susilnem

@susilnem

Copy link
Copy Markdown
Member Author

@szabozoltan69 , Can you check and verify this before merging?

Here's the output I got:
image

@szabozoltan69

szabozoltan69 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

I checked the output before and after the change.
It's great.
There is some slight change, giving
final_report_details": null
when there is no final report, but that is fine.

The old one looked like:

      "final_report_details": {
        "title": "",
        "national_society": null,
        "disaster_type": null,
        "type_of_dref": null,
        "appeal_code": "",
        "country": null,
        "status": null,
        "date_of_approval": null
      },
   – the new is better.

@szabozoltan69 szabozoltan69 marked this pull request as ready for review June 11, 2026 08:46
@szabozoltan69 szabozoltan69 merged commit 1be9874 into develop Jun 11, 2026
3 checks passed
@szabozoltan69 szabozoltan69 deleted the feature/optimise-active-dref branch June 11, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants