Skip to content

Feat/compute ni n#33

Merged
mdupaysign merged 7 commits into
devfrom
feat/compute_Ni_N
Jul 1, 2026
Merged

Feat/compute ni n#33
mdupaysign merged 7 commits into
devfrom
feat/compute_Ni_N

Conversation

@mdupaysign

Copy link
Copy Markdown
Collaborator

@mdupaysign mdupaysign self-assigned this Jun 29, 2026
@mdupaysign mdupaysign requested a review from leavauchier June 29, 2026 14:03
Comment thread lidar_for_fuel/pad_profile/build_vertical_strata.py
Comment thread lidar_for_fuel/pad_profile/build_vertical_strata.py
Comment thread lidar_for_fuel/pad_profile/build_vertical_strata.py Outdated
Comment thread lidar_for_fuel/pad_profile/compute_ni_n.py
Comment thread test/pad_profile/test_build_vertical_strata.py Outdated
Comment thread configs/config.yaml
limit_N_points: 400
limit_flight_agl: 800

z0: 0.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si tu commences à avoir beaucoup de paramètres è ajouter dans cette section, tu peux faire une sous-section strata par exemple, ce sera peut-être plus facile à terme

Comment thread lidar_for_fuel/pad_profile/build_vertical_strata.py Outdated
Comment thread lidar_for_fuel/pad_profile/calculate_pad_profile.py Outdated
assert cos_theta == 1.0


def test_pad_metrics_core_returns_ni_n_min_layer_with_default_strata_shape():

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

à mon avis tu peux merger ce test avec test_pad_metrics_core_returns_none_when_too_few_points pour en faire un test qui vérifie que les sorties ont bien le format attendu

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups, je t'ai dit des conneries, je pensais merger avec test_pad_metrics_core_scanning_angle_false_returns_one seulement, histoire de ne lancer qu'une fois pad_metrics_core pour vérifier tous les formats de sortie à la fois, là ça fait moins de sens de merger aussi avec test_pad_metrics_core_returns_none_when_too_few_points vu qu'il faut lancer pad_metrics_core avec 2 jeux de paramètres différents, désolée

Comment thread test/pad_profile/test_main_pad_profile.py Outdated
@mdupaysign mdupaysign merged commit 43e6970 into dev Jul 1, 2026
1 check passed
@mdupaysign mdupaysign deleted the feat/compute_Ni_N branch July 1, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants