Added MediaError handling#36
Open
pietervanleeuwen wants to merge 48 commits intoIIIF-Commons:masterfrom
Open
Conversation
rickrolling downloads
British library A/V
Fix for handling both temporal and spatial parameters from the url. We had an issue with a parameter (ticket-=<ticketid>) being detected as a temporal fragment resulting in unexpected temporal behaviour of the player.
Update AVComponent.ts
…ponent Objects to be constructed with the posterCanvas image expanded by default
…tercanvas-expand-arg Enables AVComponent Objects to be constructed with the posterCanvas image as expanded
Not all media is always available or playable by a browser, in this case the MediaError event is being thrown on the avcomponent so that it can be handled. For an example see examples/index.html For more details about MediaErrror see https://developer.mozilla.org/en-US/docs/Web/API/MediaError
|
This makes sense to me, but I think we need to account for i18n of the error messages.... though I suppose that is an upstream concern from the perspective of this component. |
…onent into IIIF-Commons-master
Syncing with IIIF-Commons updates
Extended player
It then falls back to the media duration and updates everything to make this work correctly
With large manifests this causes a lot of data to be loaded before a playout is actually requested. Changed this behaviour to only preload metadata (required to determine duration if this is ommited in the manifest) once a canvas has been made visible preload is set to auto and on canplaythrough the play button becomes available for the requested canvas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all media is always available or playable by a browser, in this case the MediaError event is being thrown on the avcomponent so that it can be handled.
For an example see examples/index.html
For more details about MediaErrror see https://developer.mozilla.org/en-US/docs/Web/API/MediaError