Skip to content

0485 contentstate canvas region#669

Open
giacomomarchioro wants to merge 4 commits intoIIIF:masterfrom
giacomomarchioro:0485-contentstate-canvas-region
Open

0485 contentstate canvas region#669
giacomomarchioro wants to merge 4 commits intoIIIF:masterfrom
giacomomarchioro:0485-contentstate-canvas-region

Conversation

@giacomomarchioro
Copy link
Copy Markdown
Contributor

Fix #591.

Url encoded using: https://iiif.io/api/content-state/1.0/#631-javascript (different from what proposed in the issue).

Further testing might be necessary after deployment.

@glenrobson
Copy link
Copy Markdown
Member

Merge to local branch then check tests and if OK group happy to merge.

@giacomomarchioro
Copy link
Copy Markdown
Contributor Author

I wasn't able to check it locally due to some conflicts with jekyll. I'll try again in another computer.

@giacomomarchioro giacomomarchioro force-pushed the 0485-contentstate-canvas-region branch from 26f375c to 63bc18c Compare March 13, 2026 14:58
Comment thread recipe/0485-contentstate-canvas-region/index.md Outdated
@glenrobson
Copy link
Copy Markdown
Member

I think to move this locally we need to:

If you haven't already cloned the IIIF repo:

git clone https://github.com/IIIF/cookbook-recipes.git
cd cookbook-recipes
  1. Add the fork as a remote
git remote add giacomo https://github.com/giacomomarchioro/cookbook-recipes.git
git remote -v
  1. Fetch the forks branches:
git fetch giacomo
  1. Check out the branch locally
git checkout -b 0485-contentstate-canvas-region giacomo/0485-contentstate-canvas-region
  1. Push to the IIIF repo
git push origin 0485-contentstate-canvas-region
  1. Create new pull request with the IIIF repo version of 0485-contentstate-canvas-region

giacomomarchioro and others added 2 commits March 27, 2026 14:41
Co-authored-by: Stephen Fraser <stephenwf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

id in Recipe 485 is wrong

3 participants