chore: Migrate all the hardcoded messages and emails in english to bundle.properties for password reset service.#12544
Conversation
…ndle.properties for password reset service. Closes IQSS#12536 Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
| notification.email.passwordResetCompleted.subject=Dataverse Password Reset Successfully Changed | ||
| notification.email.datasetWasCreated=Dataset "<a href = "{0}">{1}</a>" was just created by {2} in the {3} collection. | ||
| notification.email.datasetWasMoved=Dataset "<a href = "{0}">{1}</a>" was just moved by {2} to the {3} collection. | ||
| notification.email.requestedFileAccess=You have requested access to a file(s) in dataset "<a href = "{0}">{1}</a>". Your request has been sent to the managers of this dataset who will grant or reject your request. If you have any questions, you may reach the dataset managers using the "Contact" link on the upper right corner of the dataset page. |
There was a problem hiding this comment.
I'm just putting this at the bottom.
At https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12544/1/consoleFull there was an unrelated failure:
TASK [dataverse : install docker-ce repo] **************************************
fatal: [localhost]: FAILED! => {"changed": false, "dest": "/etc/yum.repos.d/docker-ce.repo", "elapsed": 0, "gid": 0, "group": "root", "mode": "0644", "msg": "Connection failure: [ASN1: NOT_ENOUGH_DATA] not enough data (_ssl.c:4192)", "owner": "root", "secontext": "system_u:object_r:system_conf_t:s0", "size": 811, "state": "file", "uid": 0, "url": "https://download.docker.com/linux/centos/docker-ce.repo"}
I kicked off https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12544/2/
There was a problem hiding this comment.
Hello @pdurbin Thanks for looking into the PR. You want the new properties added to the bottom of the file Bundle.properties?
There was a problem hiding this comment.
@mahendrapaipuri thanks for the PR! No, where you put them is fine. Thanks!
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
2 participants
What this PR does / why we need it: Improve internationalization
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: