Be able to use json and soap transport on the same port#86
Merged
Conversation
|
Contributor
Author
|
@lilgallon @xhanin I’m considering using a single port for both OCPP and an API. Any thoughts on the proposed changes? |
Added a `newMessageId` lambda parameter to `WebsocketClient` to enable custom message ID generation, defaulting to UUID.randomUUID. Updated tests to utilize this new parameter, improving test reliability by using predefined message IDs.
…guration. This change separates the server transport logic from the server configuration, improving modularity and testability. It replaces direct port handling with transport-based server initialization and updates associated tests accordingly. Fix #83
pbourseau
force-pushed
the
feat/soap-json-same-port
branch
from
5cf2631 to
cbcae2a
Compare
Contributor
Author
|
@pbourseau Thanks for the rebase. Do you think this is ready to be merged, or is there anything else needed on your side? |
Contributor
|
Hi @juherr, yes I am take care of testing and updating our projects to ensure it all still works with your changes, and if so I will merge and publish a new version. Thank you very much for all your contributions 🙏 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #83
(includes changes from #85)