Skip to content

Allow to manage and subscribe to incidents#1392

Open
BastianLedererIcinga wants to merge 3 commits into
mainfrom
feature/incidents
Open

Allow to manage and subscribe to incidents#1392
BastianLedererIcinga wants to merge 3 commits into
mainfrom
feature/incidents

Conversation

@BastianLedererIcinga

@BastianLedererIcinga BastianLedererIcinga commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

resolve #1358
requires Icinga/icinga-notifications-web#472

Add a new Subscribe button to QuickActions, to that allows to subscribe to the incident matching the Host/Service.

The existing Acknowledge/Unacknowledge option also serves as manage/unmanage of the matching incident.

Users that have no notification contact configured will see an error message when trying to subscribe, and a warning when acknowledging.

A new Notification Recipients section is added to both Host- and Sevicedetail, showing the current recipients and subscribers. The manager is highlighted with the redesigned ack badge suggested in #1358 (comment).

@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Jul 15, 2026
@BastianLedererIcinga
BastianLedererIcinga force-pushed the feature/incidents branch 13 times, most recently from b67ee1d to d467e78 Compare July 15, 2026 06:13
@nilmerg
nilmerg requested a review from sukhwinder33445 July 15, 2026 11:23
@sukhwinder33445

Copy link
Copy Markdown
Contributor

Please mention the required PR Icinga/icinga-notifications-web#472 in the description.

@sukhwinder33445 sukhwinder33445 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the alignment of the new ack badge.

Image

Comment thread library/Icingadb/Notifications/SubscriptionForm.php
Comment thread library/Icingadb/Notifications/ManagesIncidents.php
Comment thread library/Icingadb/Common/HostLinks.php
Comment thread library/Icingadb/Common/ServiceLinks.php
Comment thread library/Icingadb/Notifications/SubscribeIncidents.php Outdated
Comment thread library/Icingadb/Notifications/SubscriptionForm.php Outdated
Comment thread library/Icingadb/Widget/Detail/QuickActions.php Outdated
@sukhwinder33445

Copy link
Copy Markdown
Contributor

One more thing I noticed: once you subscribe to and then unsubscribe from an incident in the incident detail view, subscribing again is not possible and throws an error, because the unsubscribe removes the incident_contact DB entry entirely.
Using the QuickAction introduced with this PR always works.

@BastianLedererIcinga

Copy link
Copy Markdown
Contributor Author

One more thing I noticed: once you subscribe to and then unsubscribe from an incident in the incident detail view, subscribing again is not possible and throws an error, because the unsubscribe removes the incident_contact DB entry entirely. Using the QuickAction introduced with this PR always works.

As discussed in person, this an unrelated bug, caused by the IncidentQuickActions not setting the changed_at column.

@sukhwinder33445 sukhwinder33445 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread library/Icingadb/Notifications/SubscriptionForm.php Outdated
Add a subscribe/unsubscribe option to the `QuickActions`
and manage/unamnage related incidents with the existing
acknowledge
Use the `check-circle` icon in the ack-badge, matching the one on the Acknowledge button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to manage and subscribe to Icinga Notification Incidents

3 participants