Conditional report actions#276
Conversation
8bc050b to
5788e38
Compare
|
I'm not sure about the whole context. But have you considered just disabling the non-available actions and including a tool tip that clarifies the reason, e.g. "PDF-Export not configured"? My assumption is users might be looking for certain actions and wonder why they suddenly disappear or just expect certain options, as they're available in other modules. Here are a few questions, that are important for deciding, what the better option would be.
|
This PR just mimics the behavior of icingaweb itself, which hides the download as PDF button from the tab bar under similar conditions.
There is no way to know that, the reason the PDF export button is not available is always the same though, there is no hook implementing the
It is always on the admin to solve this. |
dbea517 to
5383826
Compare
Only show actions if there is actually an exporter for it.
Draft for now because of an issue that prevents
PrintableHtmlDocumentto be moved to icingaweb Icinga/icingaweb2#5510This serves as a step toward getting rid of pdfexport as a requirement for reporting, but does not get rid of this dependency entirely.
This combined with the changes made in #275 should allow us to remove pdfexport as a requirement. It is still not possible to use any module that implements the Pdfexport hook but at least the module is able to show reports in the web app and export to CSV and JSON.