fix(mailer): harden Resend env and sender DNS fallback#947
Open
IgorGanapolsky wants to merge 4 commits intomainfrom
Open
fix(mailer): harden Resend env and sender DNS fallback#947IgorGanapolsky wants to merge 4 commits intomainfrom
IgorGanapolsky wants to merge 4 commits intomainfrom
Conversation
scripts/billing.js already reads both env var names. The mailer module only read the bare `RESEND_API_KEY`, which meant any future operator who set only the `THUMBGATE_`-prefixed variant would silently skip every email with `no_api_key`. This harmonizes the two readers and adds a positive unit test. No regression vs. production today — Railway sets the bare name via `.github/workflows/deploy-railway.yml:148` and the 2026-04-17 welcome email confirmed that path works. This is defensive. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
✨ Submitted to Merge by @IgorGanapolsky. It will be added to the merge queue once all branch protection rules pass and there are no merge conflicts with the target branch. See more details here. |
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Owner
Author
|
/trunk merge |
IgorGanapolsky
changed the title
Owner
Author
|
/trunk merge |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- accept THUMBGATE_RESEND_API_KEY as a fallback for RESEND_API_KEY\n- fall back to onboarding@resend.dev when the configured sender domain is missing Resend DKIM/MX/SPF DNS\n- keep reply/unsubscribe defaults deliverable until thumbgate.app is registered and verified\n\n## Verification\n- npm run feedback:summary\n- npm run test:mailer\n- npm run test:billing\n- git diff --check\n- node --check scripts/mailer/resend-mailer.js && node --check scripts/billing.js\n- live DNS check: thumbgate.app Resend DNS records are absent / NXDOMAIN\n