[NC] Fix #179 Node Constraints OutSmooth not working#197
Merged
ManlyMarco merged 2 commits intoIllusionMods:mainfrom Feb 14, 2026
Merged
[NC] Fix #179 Node Constraints OutSmooth not working#197ManlyMarco merged 2 commits intoIllusionMods:mainfrom
ManlyMarco merged 2 commits intoIllusionMods:mainfrom
Conversation
[NC] Prevent Nodes from desyncing with the actual object [NC] Fix resetChild not respecting animation in/out timers Signed-off-by: Lusiocc <252649741+Lusiocc@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes Node Constraints “OutSmooth” behavior (Issue #179) by making disconnect smoothing restore original transforms correctly and by preventing immediate resets from bypassing animation in/out timers, reducing visible desync/drift between backend node data and rendered transforms.
Changes:
- Refactors disconnect smoothing to lerp/slerp back to original position/rotation/scale when
resetOriginal*is enabled. - Adds an
updateTimerparameter toSmoothDisconnectUpdateto avoid decrementing timers multiple times per frame. - Captures
smoothStartValueon enable/disable transitions and ensuresoriginalChildScaleis recorded when enabling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Lusiocc <252649741+Lusiocc@users.noreply.github.com>
ManlyMarco
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179
Prevent Nodes from desyncing with the actual object
Fix resetChild not respecting animation in/out timers
Tested a few different scenes in the games and none had problems from that change.