Merged
Conversation
Add wildcard search support to ModMatchFilter Implemented support for wildcard patterns (* and ?) in mod searches. Added logic to detect and process wildcard queries using regular expressions, allowing flexible matching against mod Name, Guid, or FileName. Wildcard search is only applied when not filtering by specific columns.
There was a problem hiding this comment.
Pull request overview
This PR adds wildcard search support (* and ?) to ModMatchFilter, enabling pattern-based matching against mod Name, Guid, or FileName when the search query includes wildcard characters and is not using the existing same:* column-style filter.
Changes:
- Detect wildcard queries in
ContainsStringsand enable a wildcard-search mode. - Precompute wildcard matches using escaped regex patterns and store matches in
_sameMods. - Update
Filter()to return cached wildcard matches for mod rows.
Comments suppressed due to low confidence (1)
src/KKManager.Core/Util/ModMatchFilter.cs:49
- In wildcard mode (
_isWildcardSearch),Filter()still calls_textMatchFilter.Filter(modelObject)for every row even though the result is ignored for mods. This can be a hot path on large lists sinceTextMatchFiltertypically scans multiple columns. Consider short-circuiting: if_isMod && _isWildcardSearch, return_sameMods.Contains(modelObject)before computingtextMatch(and keep the existing behavior for the non-wildcard paths).
{
bool textMatch = _textMatchFilter.Filter(modelObject);
if (_isMod && ((_isFilterCol && textMatch) || _isWildcardSearch))
{
return _sameMods.Contains(modelObject);
}
return textMatch;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ManlyMarco
approved these changes
Apr 14, 2026
Collaborator
ManlyMarco
left a comment
There was a problem hiding this comment.
Works as described in mod and plugin windows. Thanks for the PR.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wildcard search support to ModMatchFilter
Implemented support for wildcard patterns (* and ?) in mod searches. Added logic to detect and process wildcard queries using regular expressions, allowing flexible matching against mod Name, Guid, or FileName. Wildcard search is only applied when not filtering by specific columns.