Open
Conversation
konstantinstadler
requested changes
Oct 18, 2023
Member
konstantinstadler
left a comment
konstantinstadler
left a comment
There was a problem hiding this comment.
Great effort and many thanks for that.
Can you please provide more documentation on the new functions:
- Make clear if it is a "public" function or just something used internally. Please add any breaking/api modifiying changes into the CHANGELOG
- Please document the new functions with a numpy style docstring.
- Ideally, there should be unit tests for these function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! In this PR I splitted very large functions into small.