improvement(sync-secrets): add icon to show the sync status on secrets#5959
improvement(sync-secrets): add icon to show the sync status on secrets#5959
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile SummaryThis PR adds visual sync-status indicators to the Secrets Overview page: a shared
Confidence Score: 4/5Safe to merge after fixing the popover content mismatch, which causes misleading labels for failed/running syncs. One P1 logic bug: the aggregate popover always shows all filtered syncs regardless of the badge state (failed/running/succeeded), making the title 'Failed Syncs' incorrect when other-status syncs are also listed. The remaining finding is a P2 date formatting nit. No security or data concerns. frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview/SecretSyncStatusBadgeOverview.tsx — popover renders wrong sync subset
|
| Filename | Overview |
|---|---|
| frontend/src/components/secret-syncs/SecretSyncStatusBadge.tsx | Extended with tooltip showing last-synced timestamp and failure reason; minor date format issue with lowercase aaa period token. |
| frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview/SecretSyncStatusBadgeOverview.tsx | New component showing aggregate sync status badge with popover; popover renders all filteredSyncs regardless of badge state (failed/running/succeeded), making the title misleading. |
| frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncRow.tsx | Tooltip logic moved out of this row and into the shared SecretSyncStatusBadge component; clean refactor, no issues. |
| frontend/src/pages/secret-manager/OverviewPage/OverviewPage.tsx | Inserts SecretSyncStatusBadgeOverview badge in the toolbar and makes sticky column headers conditional on multi-env view. |
Reviews (2): Last reviewed commit: "fix: refactor badge to be a component an..." | Re-trigger Greptile
frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 190cad387d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
frontend/src/pages/secret-manager/OverviewPage/OverviewPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview.tsx
Outdated
Show resolved
Hide resolved
scott-ray-wilson
left a comment
There was a problem hiding this comment.
nice feature! couple of comments
frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview.tsx
Outdated
Show resolved
Hide resolved
|
@greptile check the changes again |
improvement(sync-secrets): add icon to show the sync status on secrets
Context
Adds an icon to show the status of sync secrets when a sync is happening. This helps the user know which secret might have failed
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).