Skip to content

improvement(sync-secrets): add icon to show the sync status on secrets#5959

Merged
adilsitos merged 8 commits intomainfrom
feat/adilsitos/secrets-157
Apr 8, 2026
Merged

improvement(sync-secrets): add icon to show the sync status on secrets#5959
adilsitos merged 8 commits intomainfrom
feat/adilsitos/secrets-157

Conversation

@adilsitos
Copy link
Copy Markdown
Contributor

@adilsitos adilsitos commented Apr 7, 2026

Context

Adds an icon to show the status of sync secrets when a sync is happening. This helps the user know which secret might have failed

Screenshots

image image image

Steps to verify the change

  • create a secret sync
  • Perform a sync
  • Check that the sync is changing the icon
  • Create a sync that fails
  • Check that the icon is changed and the user know that the sync failed

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@linear
Copy link
Copy Markdown

linear bot commented Apr 7, 2026

@maidul98
Copy link
Copy Markdown
Collaborator

maidul98 commented Apr 7, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This PR adds visual sync-status indicators to the Secrets Overview page: a shared SecretSyncStatusBadge tooltip (showing last-synced time and failure details) is extracted into a reusable component, and a new SecretSyncStatusBadgeOverview aggregate badge with a popover is added to the toolbar.

  • Popover content mismatch: SecretSyncStatusBadgeOverview always renders the full filteredSyncs list in its popover, but the title reads "Failed Syncs" / "Currently Syncing" — only the matching subset of syncs should be displayed to avoid misleading users about which syncs are in each state.

Confidence Score: 4/5

Safe to merge after fixing the popover content mismatch, which causes misleading labels for failed/running syncs.

One P1 logic bug: the aggregate popover always shows all filtered syncs regardless of the badge state (failed/running/succeeded), making the title 'Failed Syncs' incorrect when other-status syncs are also listed. The remaining finding is a P2 date formatting nit. No security or data concerns.

frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview/SecretSyncStatusBadgeOverview.tsx — popover renders wrong sync subset

Vulnerabilities

No security concerns identified. This is a purely frontend UI change; no user-controlled input is used to form URLs or server requests, and no credentials or sensitive data are exposed.

Important Files Changed

Filename Overview
frontend/src/components/secret-syncs/SecretSyncStatusBadge.tsx Extended with tooltip showing last-synced timestamp and failure reason; minor date format issue with lowercase aaa period token.
frontend/src/pages/secret-manager/OverviewPage/components/SecretSyncStatusBadgeOverview/SecretSyncStatusBadgeOverview.tsx New component showing aggregate sync status badge with popover; popover renders all filteredSyncs regardless of badge state (failed/running/succeeded), making the title misleading.
frontend/src/pages/secret-manager/IntegrationsListPage/components/SecretSyncsTab/SecretSyncTable/SecretSyncRow.tsx Tooltip logic moved out of this row and into the shared SecretSyncStatusBadge component; clean refactor, no issues.
frontend/src/pages/secret-manager/OverviewPage/OverviewPage.tsx Inserts SecretSyncStatusBadgeOverview badge in the toolbar and makes sticky column headers conditional on multi-env view.

Reviews (2): Last reviewed commit: "fix: refactor badge to be a component an..." | Re-trigger Greptile

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 190cad387d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice feature! couple of comments

@adilsitos
Copy link
Copy Markdown
Contributor Author

@greptile check the changes again

Copy link
Copy Markdown
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adilsitos adilsitos merged commit 291ebd6 into main Apr 8, 2026
7 checks passed
bernie-g pushed a commit that referenced this pull request Apr 9, 2026
improvement(sync-secrets): add icon to show the sync status on secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants