Skip to content

feat: add option to disable update check#248

Merged
Inrixia merged 1 commit into
Inrixia:masterfrom
Chaostheorie:master
Sep 12, 2025
Merged

feat: add option to disable update check#248
Inrixia merged 1 commit into
Inrixia:masterfrom
Chaostheorie:master

Conversation

@Chaostheorie

Copy link
Copy Markdown
Contributor

This adds an arg to toggle the update check. The default is set to true to retain the old behaviour.

This adds an arg to toggle the update check.
@Inrixia

Inrixia commented Sep 12, 2025

Copy link
Copy Markdown
Owner

What's the rationale behind adding this?

@Chaostheorie

Copy link
Copy Markdown
Contributor Author

I personally do not want to ping GitHub on every startup, that's about it. It also led to some issues while packaging it within a nix sandbox.

@Inrixia

Inrixia commented Sep 12, 2025

Copy link
Copy Markdown
Owner

Have you verified the argument is working for you with a build running this fork?

@Chaostheorie

Copy link
Copy Markdown
Contributor Author

Yes, I did, the patch below with sanityCheck=true and updateCheck=false can be used to verify it with some output too,

diff --git i/src/float.ts w/src/float.ts
index c184afe..bc48a66 100644
--- i/src/float.ts
+++ w/src/float.ts
@@ -74,6 +74,8 @@ process.on("SIGTERM", () => process.exit(143));
 					latest.version
 				}.\nHead to {cyanBright https://github.com/Inrixia/Floatplane-Downloader/releases} to update!\n`,
 			);
+	} else {
+		console.log("skipped update");
 	}

 	if (args.sanityCheck) {

@Inrixia Inrixia merged commit 5dd47dd into Inrixia:master Sep 12, 2025
3 of 5 checks passed
@Inrixia

Inrixia commented Sep 12, 2025

Copy link
Copy Markdown
Owner

Lgtm

@Inrixia

Inrixia commented Sep 12, 2025

Copy link
Copy Markdown
Owner

Ah ugh, I forgot to check the branch. In the future please pr to the dev branch not master. I'll fix it

@Chaostheorie

Copy link
Copy Markdown
Contributor Author

Thank you for the quick merge/review. I'll keep the branch rules in mind for my next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants