feat: add option to disable update check#248
Merged
Merged
Conversation
This adds an arg to toggle the update check.
Owner
|
What's the rationale behind adding this? |
Contributor
Author
|
I personally do not want to ping GitHub on every startup, that's about it. It also led to some issues while packaging it within a |
Owner
|
Have you verified the argument is working for you with a build running this fork? |
Contributor
Author
|
Yes, I did, the patch below with |
Owner
|
Lgtm |
Owner
|
Ah ugh, I forgot to check the branch. In the future please pr to the dev branch not master. I'll fix it |
Contributor
Author
|
Thank you for the quick merge/review. I'll keep the branch rules in mind for my next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an arg to toggle the update check. The default is set to
trueto retain the old behaviour.