feat(claim-voting): implement DAO voting mechanism - #106
Merged
Conversation
- Snapshot voter eligibility at claim-filing time (DataKey::ClaimVoters) Fairness rationale documented inline: holders who terminate mid-vote retain their ballot; late joiners cannot influence existing claims. - Votes are immutable after first cast (DataKey::Vote written once). Prevents last-minute flip attacks; tally reconciliation is O(1). - Running approve_votes / reject_votes updated transactionally inside vote_on_claim; no O(n) scan at finalization. - Auto-finalization on simple majority inside vote_on_claim. finalize_claim() settles by plurality after vote_deadline; tie Rejected. - Events: ClaimFiled and VoteLogged carry enough data for the Next.js claim detail timeline. ClaimSettled emitted on state transition. - ContractError enum with typed error codes; require_auth() on claimant and voter prevents address spoofing. - Pause guard on file_claim and vote_on_claim via DataKey::Paused. - test_seed_policy / test_remove_voter helpers gated behind testutils feature. - 16 integration tests covering: non-voter rejection, double-vote, vote-flip, majority approve/reject, finalize after deadline, tie, snapshot isolation, mid-vote termination, adversarial bloat, events.
|
@zeekman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #12