feat(admin): privileged admin module with two-step rotation and audit… - #108
Merged
Conversation
… events
- Two-step admin rotation (propose_admin / accept_admin / cancel_admin).
Incoming admin must prove key control before handoff completes, preventing
lockout from typos or uncontrolled keys. cancel_admin lets current admin
withdraw a pending proposal.
- require_admin() helper loads admin from storage and calls require_auth();
cannot be spoofed by mismatched signers.
- set_token: update treasury token address with old/new audit event.
- pause / unpause: circuit-breaker for file_claim and vote_on_claim;
existing votes and tallies are unaffected.
- drain: emergency treasury recovery; admin must authorize; amount > 0
enforced before token::transfer is invoked.
- initialize guard: AlreadyInitialized prevents re-initialization attacks.
- All mutations emit structured events keyed on ('admin', '<action>') so
NestJS admin_audit_log can route by topic[1] without per-action parsers.
- Cargo.toml: added testutils feature flag for test-only entrypoints.
- storage.rs: added Paused, PendingAdmin DataKey variants and helpers.
- token.rs: removed dead_code allow now that drain uses transfer.
- Centralization disclosure, multisig guidance, and future timelock seams
documented inline in admin.rs for auditors.
- 20 tests covering: full privilege matrix, two-step rotation, hijack
prevention, event emission, zero/negative drain, double-initialize.
|
@zeekman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #16