Skip to content

CompatHelper: bump compat for FMM3D in [weakdeps] to 2, (keep existing compat)#147

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
compathelper/new_version/2026-03-10-00-22-54-805-04246103902
Open

CompatHelper: bump compat for FMM3D in [weakdeps] to 2, (keep existing compat)#147
github-actions[bot] wants to merge 1 commit into
mainfrom
compathelper/new_version/2026-03-10-00-22-54-805-04246103902

Conversation

@github-actions

Copy link
Copy Markdown

This pull request changes the compat entry for the FMM3D package from 1 to 1, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@maltezfaria maltezfaria force-pushed the compathelper/new_version/2026-03-10-00-22-54-805-04246103902 branch from a005f7f to 111feb7 Compare March 10, 2026 00:23
@maltezfaria

Copy link
Copy Markdown
Member

@tanderson92 this is what you were mentioning regarding the convention on FMM3D changing right? We probably want then to modify the wrappers and pin the compat entry to 2 only.

@tanderson92

Copy link
Copy Markdown
Member

@tanderson92 this is what you were mentioning regarding the convention on FMM3D changing right? We probably want then to modify the wrappers and pin the compat entry to 2 only.

Indeed that is precisely what we should do. This is already done on the #141 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants