Fix free variable calculation#152
Merged
Merged
Conversation
The handling of '__let x = e1 __in e2' (which, like in OCaml lets you assign to a temporary variable in the middle of an expression), was not handling the fact that the scope of the variable 'x' is just 'e2'. In particular, the :metadata command was sometimes listing these variables as global variables that are assigned to by a function instead of ignoring them (because they are local variables).
nikolaykosarev
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handling of '__let x = e1 __in e2' (which, like in OCaml lets you
assign to a temporary variable in the middle of an expression), was not
handling the fact that the scope of the variable 'x' is just 'e2'.
In particular, the :metadata command was sometimes listing these
variables as global variables that are assigned to by a function instead of
ignoring them (because they are local variables).