Handle unsupported /b en <type> entity mappings without stacktraces - #490
Merged
Conversation
2 tasks
Copilot
AI
changed the title
[WIP] Fix stacktrace on entity placement with /b en
Handle unsupported May 25, 2026
/b en <type> entity mappings without stacktraces
NotMyFault
marked this pull request as ready for review
May 25, 2026 10:20
Member
|
Does that even address the linked issue? |
Member
AI thinks so, but the error is gone and entities are spawning. |
NotMyFault
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458
/b en <type>could throw when the selected WorldEditEntityTypecannot be adapted to a Bukkit entity class on the running server version. This change converts that failure path into the existing user-facing “cannot spawn” flow.Entity adaptation hardening (
EntityBrush#spawn)BukkitAdapter.adapt(entityType).getEntityClass()with targeted exception handling (IllegalArgumentException).voxelsniper.brush.entity.cannot-spawnand return early (no thrown stacktrace).Null entity class handling
nullentity class, emit the samecannot-spawncaption and exit before spawn attempts.Behavioral outcome