refactor: align framework-init props with plugin-laravel - #8
Merged
Merged
Conversation
Rename the PropertyNotSetInConstructor helpers introduced in the previous commit to match psalm/plugin-laravel's Handlers\Diagnostics\SuppressHandler, so the two plugins' framework-initialised-property handlers read the same: - FRAMEWORK_INITIALISED_PROPERTIES -> FRAMEWORK_INITIALIZED_PROPERTIES_BY_FQCN - markFrameworkInitialised() -> markFrameworkInitializedProperties() - markInitialised() -> markPropertyInitialized() Keys are now the actual (mixed-case) FQCNs rather than pre-lowercased strings; ClassLikeStorageProvider::has()/get() lowercase internally, so resolution is unchanged. The declaring-class lookup falls back to null (and skips) instead of the base FQCN, matching the sibling handler. Pure rename/cosmetic: no behavioural change.
alies-dev
changed the title
alies-dev
changed the title
alies-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7 (pure rename, no behavioural change).
Renames the
PropertyNotSetInConstructorhelpers soNovaSuppressHandlerreads the same as psalm/plugin-laravel'sHandlers\Diagnostics\SuppressHandler, which uses the identicalinitialized_propertiesmechanism:FRAMEWORK_INITIALISED_PROPERTIESFRAMEWORK_INITIALIZED_PROPERTIES_BY_FQCNmarkFrameworkInitialised()markFrameworkInitializedProperties()markInitialised()markPropertyInitialized()Also:
ClassLikeStorageProvider::has()/get()lowercase internally, so resolution is unchanged.null(and skips) rather than the base FQCN, matching the sibling handler.No behavioural change. Local
phpcsandpsalmpass; the −47PropertyNotSetInConstructorresult from #7 is unchanged (re-verified on the consuming project).