Skip to content

Rmk193 fix some hcfiles font errors#2637

Merged
rmkaplan merged 7 commits into
masterfrom
rmk193--Fix-some-HCFILES-font-errors
Jun 8, 2026
Merged

Rmk193 fix some hcfiles font errors#2637
rmkaplan merged 7 commits into
masterfrom
rmk193--Fix-some-HCFILES-font-errors

Conversation

@rmkaplan

@rmkaplan rmkaplan commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The postscript failures in #2635 were the result of an argument mismatch between the POSTSCRIPTSTREAM call \SEARCHFONTFILES and the expectations of that function.

This PR also provides a brute-force patch for the DISPLAY failures for HELVETICA 6 and TIMESROMAN 24. Basicallly, asserting that TIMESROMAN can be coerced to CLASSIC, and that HELVETICA 6 can be coerced to HELVETICA 7.

Still don't know why it needs to create those display fonts when it is creating the image file, but if it asks for them, it will get a good approximation.

I tried coercing the size 13 fonts to 12, but that didn't help--it got an array error saying that an index 13 was out of bounds in a situation where 10 was perfectly fine. That reinforces the belief that there was a 10/13 swap in those notecards files--maybe byte swapping would fix those.

rmkaplan added 2 commits June 3, 2026 23:32
Fixes the HCFILES fails for postscript fonts
Brute force fix to a few other HCFILES errors
@pamoroso

pamoroso commented Jun 4, 2026

Copy link
Copy Markdown
Member

On Linux Mint 22.1 Cinnamon I ran do_hcfiles.sh locally and, unlike files.interlisp.org, the loops and notecards directories are missing altogether. This is the log file: hcfiles-fails.txt

@pamoroso

pamoroso commented Jun 4, 2026

Copy link
Copy Markdown
Member

At commit 7ee6c72 the directories loops and notecards are still missing. The fails file: hcfiles-fails.txt

@nbriggs

nbriggs commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

notecards and loops are separate git repositories that you can check out so their directories are siblings of the medley directory - then the hcfiles script should find them.

@rmkaplan

rmkaplan commented Jun 4, 2026 via email

Copy link
Copy Markdown
Contributor Author

@pamoroso

pamoroso commented Jun 4, 2026

Copy link
Copy Markdown
Member

The directories loops and notecards are actually already siblings of the medley directory, so I wonder why do_hcfiles.sh doesn't detect them:

paolo@lispmachine:~/medley$ ls
DOS  envos  loops  maiko  medley  new-gabriel  notecards

@pamoroso

pamoroso commented Jun 5, 2026

Copy link
Copy Markdown
Member

At commit a617708 I still don't get the directories loops and notecards. The fails file: hcfiles-fails.txt

@rmkaplan

rmkaplan commented Jun 5, 2026 via email

Copy link
Copy Markdown
Contributor Author

@masinter

masinter commented Jun 5, 2026

Copy link
Copy Markdown
Member

PR #2532 was an attempt to reduce some of the confusion around the sub-module / sister repository. Right now, we have things that are created by scripts in the medley repository that refer to sources not in the medley repository. in particular, the HCFILES script copies these "ordinarily sister" repositories to be under {medley}.

I marked #2532 as draft with the idea of doing one sub-module repository at a time.
This will lead to an interim state where the module structure is half-done. Is that OK with you? @rmkaplan @pamoroso

@pamoroso

pamoroso commented Jun 5, 2026

Copy link
Copy Markdown
Member

@rmkaplan Yes, the loops and notecards directories are missing also in master. The fail file of master: hcfiles-fails.txt

@masinter I don't know, so far I checked out submodules only lightly and find the feature confusing.

@rmkaplan

rmkaplan commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

I'm confused. It appears that the font 13 files in the bigger hcfiles-fails.txt are in the user-guide-v1.2> from_envos subdirectory, but there are versions of those files above in the user-guide-v1.2. And the versions higher up have already had the CR/LF swap (with a little fixing shell script that is stored at the docs/ level).

So, why is HCFILES looking at the from_envos subdirectory? Maybe that directory should be moved to obsolete so we don't waste time on it.

@rmkaplan

rmkaplan commented Jun 5, 2026 via email

Copy link
Copy Markdown
Contributor Author

@nbriggs nbriggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rmkaplan

rmkaplan commented Jun 8, 2026 via email

Copy link
Copy Markdown
Contributor Author

@nbriggs

nbriggs commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Yes. It would have shown as has having been changed since I approved it and would require reapproval if I'd jumped the gun on that.

@rmkaplan rmkaplan merged commit 82054b3 into master Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants