Fix mc_Entity being zero on the vanilla and core shader paths - #3263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Programs using
IrisVertexFormats.TERRAINreadmc_Entityas 0.SodiumTransformer.replaceMCEntityalready redeclares it on the Sodium path, the vanilla and core paths just never got the same fix. But basically the format declares it as two unnormalized shorts, so Blaze3D binds it as an integer attribute, but packs declare it as attribute vec4mc_Entity. Mods rendering custom blocks throughassignPipelinecan supply a block ID and packs can apply the block ID material instead of getting nothing.Im pretty sure that
at_midBlockhas the same issue but I haven't touched it.