Skip to content

Leverage islandora_events if it exists#1100

Draft
joecorall wants to merge 1 commit into
2.xfrom
issue-2395
Draft

Leverage islandora_events if it exists#1100
joecorall wants to merge 1 commit into
2.xfrom
issue-2395

Conversation

@joecorall

@joecorall joecorall commented Mar 31, 2026

Copy link
Copy Markdown
Member

GitHub Issue: Islandora/documentation#2395

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

A brief description of what the intended result of the PR will be and/or what
problem it solves.

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@adam-vessey

Copy link
Copy Markdown

The source_mimetype stuff is probably fine; however otherwise, there seems to be a weird smell around things.

I might be misreading, but everything else here could be done without modifying the code of this module? As in,

  • hook_module_implements_alter() could be used to suppress the various hook implementations that islandora_events intends to replace
  • Overriding the islandora.eventgenerator class from another module could allow the service's behavior to be overridden in whatever way that is desired

Might also be served by overriding the islandora.utils class to take over the various execute*Reactions() methods?

@joecorall

Copy link
Copy Markdown
Member Author

Thanks - yeah this PR is just a hack right now so I can test the stuff locally.

@github-actions github-actions Bot added the Stale label Jul 1, 2026
@Islandora Islandora deleted a comment from github-actions Bot Jul 1, 2026
@joecorall joecorall removed the Stale label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants