Skip to content

Fix config form for Drupal 11, lint codebase, add lint/test to CI#61

Merged
aOelschlager merged 5 commits into
2.xfrom
fix-config-form-d11
Feb 4, 2026
Merged

Fix config form for Drupal 11, lint codebase, add lint/test to CI#61
aOelschlager merged 5 commits into
2.xfrom
fix-config-form-d11

Conversation

@joecorall

Copy link
Copy Markdown
Member

Drupal 11's ConfigFormBase::_construct requires a second parameter: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21ConfigFormBase.php/function/ConfigFormBase%3A%3A__construct/11.x

Since Drupal 9 doesn't have this second parameter defined, dropped it from info.yml

Without this code change, in Drupal 11 when viewing /admin/config/media/mirador an error is thrown

TypeError: Drupal\Core\Form\ConfigFormBase::__construct(): Argument #2 ($typedConfigManager) must be of type Drupal\Core\Config\TypedConfigManagerInterface, null given, called in /var/www/drupal/web/modules/contrib/islandora_mirador/src/Form/MiradorConfigForm.php on line 127 in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of /var/www/drupal/web/core/lib/Drupal/Core/Form/ConfigFormBase.php).

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@aOelschlager
aOelschlager self-requested a review January 21, 2026 18:10
@joecorall
joecorall force-pushed the fix-config-form-d11 branch from 9531607 to e86f105 Compare February 4, 2026 15:20
@joecorall joecorall changed the title Fix config form for Drupal 11 Fix config form for Drupal 11, lint codebase, add lint/test to CI Feb 4, 2026
@aOelschlager
aOelschlager merged commit a0bd4f7 into 2.x Feb 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants