Fix config form for Drupal 11, lint codebase, add lint/test to CI#61
Merged
Conversation
aOelschlager
self-requested a review
January 21, 2026 18:10
joecorall
force-pushed
the
fix-config-form-d11
branch
from
February 4, 2026 15:20
9531607 to
e86f105
Compare
aOelschlager
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drupal 11's
ConfigFormBase::_constructrequires a second parameter: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21ConfigFormBase.php/function/ConfigFormBase%3A%3A__construct/11.xSince Drupal 9 doesn't have this second parameter defined, dropped it from info.yml
Without this code change, in Drupal 11 when viewing
/admin/config/media/miradoran error is thrownAdditional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers