Add some features by Paxa · Pull Request #10 · IvanShamatov/sinatra-soap

Paxa · 2017-05-02T11:47:03Z

Added:

reply_name: param. e.g. soap :action, reply_name: 'ActionReply' do ... end
add optional soap:Header
add access to response object:

soap :action do
  response.headers = { foo: "bar" }
  response.params = { status: "success" }
  # or
  [{ foo: "bar" }, { status: "success" }]
end

attribute keys:

soap :action do
  {
    result: {
      "@status": "success",
      foo: {
        "@active": true,
        "@@content": "bar"
      }
    }
  }
end
# output:
<result status="success">
  <foo active="true">bar</foo>
</result>

If you find this useful, I will add more tests and documentation

IvanShamatov

Hi, @Paxa. Thank you for finding that project interesting. As you can see I'm not maintaining it at this moment. Actually that was my first gem ever, so you can find some strange decisions I made back there 4 years ago. If you find it usable in your project, just use fork. But for now I can't merge your PR due to some comments down there. If you would like to talk and even finish it to be production ready I'm open for discussion.
Thanks again,
Ivan

IvanShamatov · 2017-05-03T09:53:40Z

 # Specify your gem's dependencies in sinatra-soap.gemspec
 gemspec
+
+gem 'sinatra', '2.0.0.rc2'


I guess this should be moved into gemspec (well it's there).

IvanShamatov · 2017-05-03T09:55:11Z

 rvm:
-  - 1.9.3
  - 2.0.0
+  - 2.4.0


Why would you like to drop supporting for 1.9 branch without major release? Only major release should make breaking API changes

Probably updating major version will be right. 1.9 support ended 2 years ago, do you know if anyone still using it? I haven't seen it for years

https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/

IvanShamatov · 2017-05-03T09:55:55Z

        File.join(File.dirname(__FILE__), "..", "views")
      end

+      def hash_to_xml(xml, hash)


I guess this should be rewritten. Too long method with huge complexity.

Yep. But what you think about this idea in general? (@.. for xml attributes, @@content to create tag with attributes and simple content, converting array list of singularized tags)

IvanShamatov · 2017-05-03T10:00:17Z

+
      def call_action_block
        request = Soap::Request.new(env, request, params)
+        if defined?(logger) && logger


It looks like Soap::Request should know about logging and log request while/before/after execution.

IvanShamatov · 2017-05-03T10:02:03Z

      rescue Soap::Error => e
-        builder :error, locals: {e: e}, :views => self.soap_views
+        if defined?(logger) && logger
+          logger.info "SOAP Request: #{env['HTTP_SOAPACTION']} - Undefined Soap Action"


That's not correct. If we catch error that does not mean we catch Undefined Soap Action.

Right, thanks for point it

IvanShamatov · 2017-05-03T10:02:46Z


      def get_wsdl
+        if defined?(logger) && logger
+          logger.info "SOAP: wsdl request"


Thats it? seriously? Just log that wsdl request?

it was useful in my case to verify if client working correctly or not. Probably just standard sinatra's logging will be enough

IvanShamatov · 2017-05-03T10:03:25Z

+      def header
+        return orig_params[:soap_header] unless orig_params[:soap_header].nil?
+        rack_input = env["rack.input"].read
+        env["rack.input"].rewind


Prefer single quotes (rubocop)

never understood the point of this rule, afaik now days compiler is smart enough to determine if have interpolations or not...
Will update it when code is production ready

IvanShamatov · 2017-05-03T10:04:47Z

  spec.add_development_dependency "rake"
  spec.add_development_dependency "rack-test"
-  spec.add_development_dependency "debugger"
+  #spec.add_development_dependency "debugger"


Why would you remove debugger out of development dependencies?

It's only for ruby 1.9.*, I think there was some installation issues with ruby 2.4

Paxa added 9 commits May 2, 2017 18:43

Add support for response headers, reply_name, try refactor envelop tag

5823cce

Support for xml attributes

493b20a

Add .ruby-version to .gitignore

76de493

Add support for @@content

f56bb63

Access request headers, alias params = body

dfa0821

Fix reply name in wsdl, support rendering arrays

8a2046a

Support for rendering arrays

3c3dfba

Fix singularize

28244bb

alias soap_header => header

22137dc

IvanShamatov reviewed May 3, 2017

View reviewed changes

Paxa added 3 commits May 4, 2017 00:24

Update ruby versions

f9e0a1b

Update error logging

56daceb

Allow to call app level methods from soap action block

7618cdb

Conversation

Paxa commented May 2, 2017

Uh oh!

IvanShamatov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IvanShamatov left a comment •

edited

Loading