Skip to content

Fixed method GetOrdersAsync: fields fromId, toId #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JKorf merged 1 commit into from
Feb 27, 2026
+11 −11
Merged

Fixed method GetOrdersAsync: fields fromId, toId #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions OKX.Net/Clients/UnifiedApi/OKXRestClientUnifiedApiTrading.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,8 @@ public virtual async Task<WebCallResult<OKXOrder[]>> GetOrdersAsync(
string? underlying = null,
OrderType? orderType = null,
OrderStatus? state = null,
DateTime? startTime = null,
DateTime? endTime = null,
string? fromId = null,
string? toId = null,
int limit = 100,
string? instrumentFamily = null,
CancellationToken ct = default)
Expand All @@ -350,8 +350,8 @@ public virtual async Task<WebCallResult<OKXOrder[]>> GetOrdersAsync(
var parameters = new ParameterCollection();
parameters.AddOptionalParameter("instId", symbol);
parameters.AddOptionalParameter("uly", underlying);
parameters.AddOptionalParameter("before", DateTimeConverter.ConvertToMilliseconds(startTime)?.ToString(CultureInfo.InvariantCulture));
parameters.AddOptionalParameter("after", DateTimeConverter.ConvertToMilliseconds(endTime)?.ToString(CultureInfo.InvariantCulture));
parameters.AddOptionalParameter("before", fromId);
parameters.AddOptionalParameter("after", toId);
parameters.AddOptionalParameter("limit", limit.ToString());
parameters.AddOptionalParameter("instFamily", instrumentFamily);

Expand Down
6 changes: 3 additions & 3 deletions OKX.Net/Interfaces/Clients/UnifiedApi/IOKXRestClientUnifiedApiTrading.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,13 @@ Task<WebCallResult<OKXOrder[]>> GetOrderHistoryAsync(InstrumentType instrumentTy
/// <param name="underlying">Underlying</param>
/// <param name="orderType">Order Type</param>
/// <param name="state">State</param>
/// <param name="startTime">Pagination of data to return records earlier than the requested ts</param>
/// <param name="endTime">Pagination of data to return records newer than the requested ts</param>
/// <param name="fromId">Pagination of data to return records earlier than the requested ordId</param>
/// <param name="toId">Pagination of data to return records newer than the requested ordId</param>
/// <param name="limit">Number of results per request. The maximum is 100; the default is 100.</param>
/// <param name="instrumentFamily">Instrument family</param>
/// <param name="ct">Cancellation Token</param>
/// <returns></returns>
Task<WebCallResult<OKXOrder[]>> GetOrdersAsync(InstrumentType? instrumentType = null, string? symbol = null, string? underlying = null, OrderType? orderType = null, OrderStatus? state = null, DateTime? startTime = null, DateTime? endTime = null, int limit = 100, string? instrumentFamily = null, CancellationToken ct = default);
Task<WebCallResult<OKXOrder[]>> GetOrdersAsync(InstrumentType? instrumentType = null, string? symbol = null, string? underlying = null, OrderType? orderType = null, OrderStatus? state = null, string? fromId = null, string? toId = null, int limit = 100, string? instrumentFamily = null, CancellationToken ct = default);

/// <summary>
/// Get recently-filled transaction details in the last 3 months.
Expand Down
8 changes: 4 additions & 4 deletions OKX.Net/OKX.Net.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@
<member name="M:OKX.Net.Clients.UnifiedApi.OKXRestClientUnifiedApiTrading.GetOrderDetailsAsync(System.String,System.Nullable{System.Int64},System.String,System.Threading.CancellationToken)">
<inheritdoc />
</member>
<member name="M:OKX.Net.Clients.UnifiedApi.OKXRestClientUnifiedApiTrading.GetOrdersAsync(System.Nullable{OKX.Net.Enums.InstrumentType},System.String,System.String,System.Nullable{OKX.Net.Enums.OrderType},System.Nullable{OKX.Net.Enums.OrderStatus},System.Nullable{System.DateTime},System.Nullable{System.DateTime},System.Int32,System.String,System.Threading.CancellationToken)">
<member name="M:OKX.Net.Clients.UnifiedApi.OKXRestClientUnifiedApiTrading.GetOrdersAsync(System.Nullable{OKX.Net.Enums.InstrumentType},System.String,System.String,System.Nullable{OKX.Net.Enums.OrderType},System.Nullable{OKX.Net.Enums.OrderStatus},System.String,System.String,System.Int32,System.String,System.Threading.CancellationToken)">
<inheritdoc />
</member>
<member name="M:OKX.Net.Clients.UnifiedApi.OKXRestClientUnifiedApiTrading.GetOrderHistoryAsync(OKX.Net.Enums.InstrumentType,System.String,System.String,System.Nullable{OKX.Net.Enums.OrderType},System.Nullable{OKX.Net.Enums.OrderStatus},System.Nullable{OKX.Net.Enums.OrderCategory},System.Nullable{System.DateTime},System.Nullable{System.DateTime},System.Int32,System.String,System.String,System.String,System.Threading.CancellationToken)">
Expand Down Expand Up @@ -5463,7 +5463,7 @@
<param name="ct">Cancellation Token</param>
<returns></returns>
</member>
<member name="M:OKX.Net.Interfaces.Clients.UnifiedApi.IOKXRestClientUnifiedApiTrading.GetOrdersAsync(System.Nullable{OKX.Net.Enums.InstrumentType},System.String,System.String,System.Nullable{OKX.Net.Enums.OrderType},System.Nullable{OKX.Net.Enums.OrderStatus},System.Nullable{System.DateTime},System.Nullable{System.DateTime},System.Int32,System.String,System.Threading.CancellationToken)">
<member name="M:OKX.Net.Interfaces.Clients.UnifiedApi.IOKXRestClientUnifiedApiTrading.GetOrdersAsync(System.Nullable{OKX.Net.Enums.InstrumentType},System.String,System.String,System.Nullable{OKX.Net.Enums.OrderType},System.Nullable{OKX.Net.Enums.OrderStatus},System.String,System.String,System.Int32,System.String,System.Threading.CancellationToken)">
<summary>
Get all incomplete orders under the current account.
<para><a href="https://www.okx.com/docs-v5/en/#order-book-trading-trade-get-order-list" /></para>
Expand All @@ -5473,8 +5473,8 @@
<param name="underlying">Underlying</param>
<param name="orderType">Order Type</param>
<param name="state">State</param>
<param name="startTime">Pagination of data to return records earlier than the requested ts</param>
<param name="endTime">Pagination of data to return records newer than the requested ts</param>
<param name="fromId">Pagination of data to return records earlier than the requested ordId</param>
<param name="toId">Pagination of data to return records newer than the requested ordId</param>
<param name="limit">Number of results per request. The maximum is 100; the default is 100.</param>
<param name="instrumentFamily">Instrument family</param>
<param name="ct">Cancellation Token</param>
Expand Down