fix: site popup clipped off-screen when location has many devices - #57
Merged
Conversation
Copilot created this pull request from a session on behalf of
Jackass4life
July 10, 2026 05:58
View session
Jackass4life
marked this pull request as ready for review
July 10, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a site with a large device count (e.g. 46 devices) caused the popup to overflow the viewport — the site name, status badge, and metadata were hidden above the visible area while only the device list was visible.
Changes
keepInView: trueadded to allbindPopup()calls (single marker, co-located marker, cluster) — Leaflet now auto-pans the map to keep the popup fully on screen after open.leaflet-popup-contentgainsmax-height: min(520px, 75vh)withoverflow-y: auto; previouslyoverflow-y: visibleexplicitly allowed unbounded overflow.device-list-scrollinner scroll cap (320px) is preserved; the outer cap ensures header/metadata rows always remain visible regardless of device count