fix(segment): render detected empty batteries - #7783
Closed
jin-li wants to merge 1 commit into
Closed
Conversation
Owner
|
@all-contributors please add @jin-li for code This is pure magic 🪄! @holopin-bot @jin-li wizard |
|
Congratulations @jin-li, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmskiypbi0001jq045xwtsg1y This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Contributor
|
I've put up a pull request to add @jin-li! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
A valid battery at 0% is currently disabled before the battery segment can render.
Remove the percentage-based no-battery check so a successfully retrieved empty battery renders as
0%.NoBatteryErrorcontinues to handle computers without a battery.Adds a regression test for a
NotChargingbattery at 0%.Fixes #7782