fix(golang): read the documented parse_go_work_file option - #7812
Merged
JanDeDobbeleer merged 1 commit intoAug 25, 2026
Conversation
JanDeDobbeleer
force-pushed
the
fix/golang-parse-go-work-file
branch
from
August 25, 2026 09:21
c8539b0 to
a9db832
Compare
JanDeDobbeleer
approved these changes
Aug 25, 2026
JanDeDobbeleer
changed the base branch from
main
to
claude/msix-appinstaller-auto-update-4893ry
August 25, 2026 09:22
JanDeDobbeleer
force-pushed
the
fix/golang-parse-go-work-file
branch
from
August 25, 2026 09:22
a9db832 to
6c2d708
Compare
📦 Release binary size reportCompares this PR's release-equivalent build against the latest published release, per OS (amd64).
🎉 Binary size shrank on at least one platform. |
JanDeDobbeleer
merged commit Aug 25, 2026
3e34bb2
into
JanDeDobbeleer:claude/msix-appinstaller-auto-update-4893ry
13 checks passed
Owner
|
@all-contributors please add @NotAFlightRisk for code This is pure magic 🪄! @holopin-bot @NotAFlightRisk wizard |
|
Congratulations @NotAFlightRisk, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmt8gqir10001l504u6f2mlht This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Contributor
|
I've put up a pull request to add @NotAFlightRisk! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Turn on
parse_go_work_fileand the go segment carries on showing whatevergo versionprints, so you get the toolchain you happen to have instaled rather than the one yourgo.workpins. With nogoon PATH it renders empty.This is so that it behaves how you documented it, and how the schema autocompletes it
It does mean
parse_work_filestops working, but that spelling is in neither the docs nor the schema - I doubt anyone has it set. The existing test set the option through the constant, wich meant it passed either way. It uses the literal key now and fails on main.Small change, close it if you'd rather not.