Skip to content

fix(golang): read the documented parse_go_work_file option - #7812

Merged
JanDeDobbeleer merged 1 commit into
JanDeDobbeleer:claude/msix-appinstaller-auto-update-4893ryfrom
NotAFlightRisk:fix/golang-parse-go-work-file
Aug 25, 2026
Merged

fix(golang): read the documented parse_go_work_file option#7812
JanDeDobbeleer merged 1 commit into
JanDeDobbeleer:claude/msix-appinstaller-auto-update-4893ryfrom
NotAFlightRisk:fix/golang-parse-go-work-file

Conversation

@NotAFlightRisk

@NotAFlightRisk NotAFlightRisk commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features). Nothing to change, the docs are the half thats already right.

Description

Turn on parse_go_work_file and the go segment carries on showing whatever go version prints, so you get the toolchain you happen to have instaled rather than the one your go.work pins. With no go on PATH it renders empty.

This is so that it behaves how you documented it, and how the schema autocompletes it

image

It does mean parse_work_file stops working, but that spelling is in neither the docs nor the schema - I doubt anyone has it set. The existing test set the option through the constant, wich meant it passed either way. It uses the literal key now and fails on main.

Small change, close it if you'd rather not.

@JanDeDobbeleer
JanDeDobbeleer force-pushed the fix/golang-parse-go-work-file branch from c8539b0 to a9db832 Compare August 25, 2026 09:21
@JanDeDobbeleer
JanDeDobbeleer changed the base branch from main to claude/msix-appinstaller-auto-update-4893ry August 25, 2026 09:22
@JanDeDobbeleer
JanDeDobbeleer force-pushed the fix/golang-parse-go-work-file branch from a9db832 to 6c2d708 Compare August 25, 2026 09:22
@github-actions

Copy link
Copy Markdown

📦 Release binary size report

Compares this PR's release-equivalent build against the latest published release, per OS (amd64).

OS Baseline This PR Delta
darwin 13.79 MB 13.78 MB -4.0 KB (-0.03%)
linux 13.46 MB 13.45 MB -4.0 KB (-0.03%)
windows 14.02 MB 13.98 MB -42.8 KB (-0.3%)

🎉 Binary size shrank on at least one platform.

@JanDeDobbeleer
JanDeDobbeleer merged commit 3e34bb2 into JanDeDobbeleer:claude/msix-appinstaller-auto-update-4893ry Aug 25, 2026
13 checks passed
@JanDeDobbeleer

Copy link
Copy Markdown
Owner

@all-contributors please add @NotAFlightRisk for code

This is pure magic 🪄! @holopin-bot @NotAFlightRisk wizard

@holopin-bot

holopin-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

Congratulations @NotAFlightRisk, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmt8gqir10001l504u6f2mlht

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@allcontributors

Copy link
Copy Markdown
Contributor

@JanDeDobbeleer

I've put up a pull request to add @NotAFlightRisk! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants