Skip to content

fix(shell): respect POSH_DISABLE_STREAMING at runtime - #7850

Merged
JanDeDobbeleer merged 5 commits into
mainfrom
jandedobbeleer-fix-streaming-idle-bug
Sep 1, 2026
Merged

fix(shell): respect POSH_DISABLE_STREAMING at runtime#7850
JanDeDobbeleer merged 5 commits into
mainfrom
jandedobbeleer-fix-streaming-idle-bug

Conversation

@JanDeDobbeleer

Copy link
Copy Markdown
Owner

Summary

This fixes the case where POSH_DISABLE_STREAMING=1 is set before initialization but the cached shell init still starts streaming on the live session.

What changed

  • removed the generation-time config gate from src/config/config.go
  • kept the live runtime guard in the generated shell scripts, so the env var is checked when the script actually initializes streaming
  • added/updated shell tests for fish, zsh, cmd, and pwsh to cover the runtime guard behavior

Validation

  • cd src && go test ./config ./shell/...

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

📦 Release binary size report

Compares this PR's release-equivalent build against the latest published release, per OS (amd64).

OS Baseline This PR Delta
darwin 14.18 MB 14.18 MB -0.0 KB (+0%)
linux 13.84 MB 13.84 MB -4.0 KB (-0.03%)
windows 14.36 MB 14.31 MB -42.8 KB (-0.29%)

🎉 Binary size shrank on at least one platform.

JanDeDobbeleer and others added 4 commits September 1, 2026 08:35
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@JanDeDobbeleer
JanDeDobbeleer merged commit 45ff338 into main Sep 1, 2026
14 checks passed
@JanDeDobbeleer
JanDeDobbeleer deleted the jandedobbeleer-fix-streaming-idle-bug branch September 1, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant