Add naive instructions to README.md for building and running.#5
Open
apetro wants to merge 2 commits into
Open
Conversation
These instructions result in an app at least launching. Looks like there's more to be done to make the launched app interesting.
ChristianMurphy
approved these changes
Feb 2, 2017
ChristianMurphy
left a comment
ChristianMurphy
left a comment
Member
There was a problem hiding this comment.
LGTM, Thanks @apetro!
|
|
||
| Build using | ||
|
|
||
| ```shell_session |
Member
There was a problem hiding this comment.
Github doesn't recognize recognize shell_session as a language, these are the aliases that will trigger code highlights. https://github.com/github/linguist/blob/master/lib/linguist/languages.yml#L3953-L3957
Member
Author
There was a problem hiding this comment.
Ah. I was relying upon the Rouge lexers supported by GitHub Pages, hadn't realized it's a different set for GitHub itself.
Member
There was a problem hiding this comment.
Interesting, I'm surprised linguist doesn't support all the same aliases as Rouge, since the two are supposed to be interchangeable. 😕 🤷♂️
Use the GitHub-supported `linguist` [name for shell sessions](https://github.com/github/linguist/blob/master/lib/linguist/languages.yml#L3986) rather than the GitHub-Pages-supported `Rouge` name for shell sessions in marking shell example for code highlighting. In practice currently a no-op, since neither `shell_session` nor `ShellSession` (nor `shell`) yield interesting highlighting for this specific code block. Nonetheless, the code highlighting language type declaration probably adds a tiny bit of value in clarifying what the example in the code block is.
ChristianMurphy
approved these changes
Feb 2, 2017
Member
Author
|
Hi Andrew,
I am going to need you to translate these messages into non technical language for me until I learn the lingo. I am lost right now.
Best wishes,
Bruce
-----------
Bruce Kirchoff
"Education is that which remains, if one has forgotten everything he learned in school."
- Einstein
…On Feb 6, 2017, 10:27 AM -0500, Andrew Petro ***@***.***>, wrote:
This instructions will no longer be correct when #2 (#2) merges. That's okay. #2 (#2) is progress. But will need to rev these instructions, or close PR and try again in light of the onejar approach of #2 (#2).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (#5 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/ARqa-a-x9lgoz4j6JuM_0q7zQxx6dD9Mks5rZzvQgaJpZM4L0uQB).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These instructions result in an app at least launching.
Looks like there's more to be done to make the launched app interesting.