Refactor: rename AdvancedTrim.Trim() --> AdvancedTrim.trim() .#6
Open
apetro wants to merge 4 commits into
Open
Refactor: rename AdvancedTrim.Trim() --> AdvancedTrim.trim() .#6apetro wants to merge 4 commits into
apetro wants to merge 4 commits into
Conversation
Style: Java method names, even static, should start w/ lowercase.
ChristianMurphy
approved these changes
Feb 2, 2017
ChristianMurphy
left a comment
ChristianMurphy
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @apetro!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syle: Java method names should be
camelCaserather thanTitleCase, soAdvancedTrim.trim( String )rather thanAdvancedTrim.Trim( String ).Supported by unit test discovering, staving off regression of the behavior of the pre-existing
Trim()method and JavaDoc documenting the behavior. (Commit sequence first tests and documents, then refactors.)(Verified
mvn packagestill succeeds, new unit test and all, and resulting.applaunches.)