Refactor: Update HAL to use std::unique_ptr and ROS2 naming conventions#3696
Open
zaynabahmad wants to merge 1 commit intoJdeRobot:humble-develfrom
Open
Refactor: Update HAL to use std::unique_ptr and ROS2 naming conventions#3696zaynabahmad wants to merge 1 commit intoJdeRobot:humble-develfrom
zaynabahmad wants to merge 1 commit intoJdeRobot:humble-develfrom
Conversation
javizqh
requested changes
Apr 10, 2026
Member
javizqh
left a comment
There was a problem hiding this comment.
We just finished with our refactor of the vacuum cleaner exercise. Please if possible update this PR to match the new files in cpp_lib in RA and common_interfaces_cpp in RI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
HAL.hppfor the Vacuum Cleaner exercise to improve memory management and adhere to ROS 2 coding standards.Changes:
std::unique_ptr<LaserData>inget_laser_data()to prevent memory leaks.snake_case_(Google/ROS 2 Style Guide).const SharedPtr&.using namespace std;to prevent namespace pollution.Testing Performed
Visual Proof
video.webm
Issue
Issue #3692