Combine multiple UIView sources to get window insets#2946
Merged
Conversation
ASalavei
reviewed
Apr 8, 2026
compose/ui/ui/src/iosMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.ios.kt
Show resolved
Hide resolved
svastven
force-pushed
the
svastven/window-insets
branch
from
fe0c81e to
52217da
Compare
mazunin-v-jb
approved these changes
Apr 9, 2026
svastven
force-pushed
the
svastven/window-insets
branch
from
52217da to
5f4f652
Compare
ASalavei
approved these changes
Apr 10, 2026
svastven
added a commit
that referenced
this pull request
Apr 10, 2026
Combine multiple UIView sources to get correct window insets. Fixes support for embedding compose views in UIKit navigation view with UIKit navigation bar and iPad insets for traffic light controls. Fixes [CMP-9931](https://youtrack.jetbrains.com/issue/CMP-9931) iOS: WindowInsets.safeDrawing does not include UINavigationBar safe area insets (regression in 1.11.0-alpha04) Test [CMP-8922](https://youtrack.jetbrains.com/issue/CMP-8922) on iPad in combination with sample provided in [CMP-9931](https://youtrack.jetbrains.com/issue/CMP-9931) This should be tested by QA - _(prerelease fix)_ Fix `UINavigationBar` safe area insets not included in `WindowInsets.safeDrawing`
svastven
added a commit
that referenced
this pull request
Apr 10, 2026
Combine multiple UIView sources to get correct window insets. Fixes support for embedding compose views in UIKit navigation view with UIKit navigation bar and iPad insets for traffic light controls. Fixes [CMP-9931](https://youtrack.jetbrains.com/issue/CMP-9931) iOS: WindowInsets.safeDrawing does not include UINavigationBar safe area insets (regression in 1.11.0-alpha04) Test [CMP-8922](https://youtrack.jetbrains.com/issue/CMP-8922) on iPad in combination with sample provided in [CMP-9931](https://youtrack.jetbrains.com/issue/CMP-9931) This should be tested by QA - _(prerelease fix)_ Fix `UINavigationBar` safe area insets not included in `WindowInsets.safeDrawing`
sekater
added a commit
that referenced
this pull request
Apr 10, 2026
…2946) (#2965) Combine multiple UIView sources to get correct window insets. Fixes support for embedding compose views in UIKit navigation view with UIKit navigation bar and iPad insets for traffic light controls. Fixes [CMP-9931](https://youtrack.jetbrains.com/issue/CMP-9931) iOS: WindowInsets.safeDrawing does not include UINavigationBar safe area insets (regression in 1.11.0-alpha04) ## Testing Test [CMP-8922](https://youtrack.jetbrains.com/issue/CMP-8922) on iPad in combination with sample provided in [CMP-9931](https://youtrack.jetbrains.com/issue/CMP-9931) This should be tested by QA ## Release Notes ### Fixes - iOS - _(prerelease fix)_ Fix `UINavigationBar` safe area insets not included in `WindowInsets.safeDrawing`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine multiple UIView sources to get correct window insets. Fixes support for embedding compose views in UIKit navigation view with UIKit navigation bar and iPad insets for traffic light controls.
Fixes CMP-9931 iOS: WindowInsets.safeDrawing does not include UINavigationBar safe area insets (regression in 1.11.0-alpha04)
Testing
Test CMP-8922 on iPad in combination with sample provided in CMP-9931
This should be tested by QA
Release Notes
Fixes - iOS
UINavigationBarsafe area insets not included inWindowInsets.safeDrawing