Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a variety of changes, including updates to linting configurations, Dockerfile improvements, code refactoring, and bug fixes. The most significant updates involve enhancing the linting setup, refactoring switch statements for better readability, and improving type safety in the codebase.
Linting and Configuration Updates:
.golangci.ymlto enable a specific set of linters, includingerrcheck,staticcheck, andgocritic, while removing deprecated configurations and adding exclusions for generated files and specific paths. [1] [2]golangci-lintas the default linting tool in.vscode/settings.jsonand configuredgoplsfor consistent formatting.golangci-lintversion fromv1.64.6tov2.1.5inci.Dockerfile.Code Refactoring:
if-elsechains intoswitchstatements for improved readability, e.g., inclean.go,workdir/preparer.go, andupgrade/service.go. [1] [2] [3]mintominValandmaxtomaxValinpkg/intrange/intrange.go.Bug Fixes:
!(A || B)with!A && !Binquery_builder.go.Reason inttoReason uintinpkg/dep/dep_graph.go.Dockerfile and Workflow Enhancements:
/app/bintoPATHin.devcontainer/Dockerfileto ensure binaries are accessible during development..github/workflows/testing.ymlto integrate lint checks into the CI pipeline.Miscellaneous Improvements:
nilchecks for slices inparser.go.intrange_test.goby using more concise syntax formapsetinitialization. [1] [2]