Update to modern handling - #93
Merged
Merged
Conversation
Jikoo
commented
Mar 19, 2026
Jikoo
commented
Owner
- Re-add Spigot support
- Use DataComponents on Paper
- This allows direct edits to the ItemStack without needing excessive ItemMeta creation and validation.
- Fix issue with removing display name not actually working
- This is probably a Paper bug, but I couldn't tell why it was happening so I stopped trying to trace it. Maybe next week I'll try to make a minimal reproduction example.
- Shade utilized PlanarWrappers classes
- Makes it easier to ensure that consumers of this API have required classes
Apparently the meta doesn't have any way to unset custom name.
May set up automatic Sonarqube-side analysis later
At some point, Spigot apparently actually made Damageable and Repairable extend ItemMeta.
Prevent non-change changes during regeneration
Owner
Author
|
Build is probably going to fail because of Sonar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.