refactor(conformance): ♻️ refactor modules and add command option routing#82
Open
JimmyPaolini wants to merge 18 commits into
Open
refactor(conformance): ♻️ refactor modules and add command option routing#82JimmyPaolini wants to merge 18 commits into
JimmyPaolini wants to merge 18 commits into
Conversation
📦 Bundle Size Report❌ 326.29 kB total (+0.00 kB, +0.0% vs base)
📊 Guidelines
Updated automatically when you push new commits. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…d remove overloads
…fy base command runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌰 Summary
Refactored the
tools/conformancetool from a static Nx generator plugin into a canonical NestJS command application usingnest-commander. All generator templates are now dedicated command modules following thenestjs-command-modulepattern, with a separate validator command module for conformance checking. The application includes interactive command selection via CLI prompts. Conformance validation is now properly wired into lint-staged and GitHub Actions CI/CD.📝 Details
nestjs-command-moduletemplate with Python validators organized inmodules/validator/python/subdirectorynestjs-service-moduleandnestjs-command-applicationtemplates@Optiondecorator in main conformance-generator command with CLI prompt for interactive command selection via DiscoveryServiceconformance:validatecommand into lint-staged for pre-commit checks and GitHub Actions validate-conventions workflow for CI/CD validation@types/mdastto devDependencies in lexico-ingestion (TypeScript-only, not runtime)🧪 Testing
All validation targets pass:
To test conformance validation locally when generator templates or instances change:
🔗 Related
Resolves the planning task to refactor conformance into a nestjs-command-application with all generators as command modules, validator as a separate command module, and proper integration of conformance validation throughout the development and CI/CD pipeline.