fix: copy input parameter defaults to output in suspend templates#35
Closed
Joibel wants to merge 1 commit into
Closed
fix: copy input parameter defaults to output in suspend templates#35Joibel wants to merge 1 commit into
Joibel wants to merge 1 commit into
Conversation
…spend templates When a suspend node times out, the output parameters need a default value (valueFrom.default) to be used. Previously, users had to manually specify the default in the output's valueFrom even when they had already defined a default on the matching input parameter. This fix automatically populates the output parameter's valueFrom.default from the matching input parameter's default when: - The output parameter has valueFrom.supplied set - The output doesn't already have a valueFrom.default - There's an input parameter with the same name that has a default This allows suspend templates with input parameters that have defaults and matching output parameters with valueFrom.supplied to work correctly when the suspend duration times out, without requiring users to duplicate the default value in the output specification. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
marked this pull request as draft
January 13, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes argoproj#12896
Motivation
This workflow apparently worked in 3.4, I haven't tried to work out why.
Modifications
We now observe the default values of the inputs if the output doesn't have defaults, for suspend templates only
Verification
New unit test, which verified the workflow passes and checks the values.
The workflow would formerly failed.
Documentation
None required, bug fix