Skip to content

Security fixes: #851, #870, #873 #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edgeinfinity1 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Security fixes: #851, #870, #873 #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73c3fb9
fix: login vulnerability
zxypro1 Mar 8, 2025
db759f7
Fixed SQL Injection vulnerability
edgeinfinity1 Dec 10, 2025
b582f91
fix
edgeinfinity1 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func queryUserList(db *sql.DB, sql string) ([]*User, error) {
return userList, nil
}

func queryUser(db *sql.DB, sql string) (*User, error) {
func queryUser(db *sql.DB, sql string, args ...interface{}) (*User, error) {
var (
username string
encryptPass string
Expand All @@ -138,7 +138,7 @@ func queryUser(db *sql.DB, sql string) (*User, error) {
useDays uint
expiryDate string
)
row := db.QueryRow(sql)
row := db.QueryRow(sql, args...)
if err := row.Scan(&id, &username, &encryptPass, &passShow, &quota, &download, &upload, &useDays, &expiryDate); err != nil {
return nil, err
}
Expand Down Expand Up @@ -343,7 +343,7 @@ func (mysql *Mysql) GetUserByName(name string) *User {
return nil
}
defer db.Close()
user, err := queryUser(db, fmt.Sprintf("SELECT * FROM users WHERE BINARY username='%s'", name))
user, err := queryUser(db, "SELECT * FROM users WHERE BINARY username=?", name)
if err != nil {
return nil
}
Expand All @@ -357,7 +357,7 @@ func (mysql *Mysql) GetUserByPass(pass string) *User {
return nil
}
defer db.Close()
user, err := queryUser(db, fmt.Sprintf("SELECT * FROM users WHERE BINARY passwordShow='%s'", pass))
user, err := queryUser(db, "SELECT * FROM users WHERE BINARY passwordShow=?", pass)
if err != nil {
return nil
}
Expand Down
9 changes: 8 additions & 1 deletion web/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,12 @@ func Auth(r *gin.Engine, timeout int) *jwt.GinJWTMiddleware {
}
})
r.POST("/auth/login", authMiddleware.LoginHandler)
r.POST("/auth/register", updateUser)
// 只有在系统未初始化时才注册公开的 /auth/register 路由
adminPass, _ := core.GetValue("admin_pass")
if adminPass == "" {
r.POST("/auth/register", updateUser)
}

authO := r.Group("/auth")
authO.Use(authMiddleware.MiddlewareFunc())
{
Expand All @@ -173,6 +178,8 @@ func Auth(r *gin.Engine, timeout int) *jwt.GinJWTMiddleware {
authO.POST("/reset_pass", updateUser)
authO.POST("/logout", authMiddleware.LogoutHandler)
authO.POST("/refresh_token", authMiddleware.RefreshHandler)
// 系统初始化后，注册功能只能在授权后使用
authO.POST("/register", updateUser)
}
return authMiddleware
}