Enable interpolation_setup to download precomputed weights for LLC90 or LLC270#220
Open
seamanticscience wants to merge 5 commits intoJuliaClimate:masterfrom
Open
Enable interpolation_setup to download precomputed weights for LLC90 or LLC270#220seamanticscience wants to merge 5 commits intoJuliaClimate:masterfrom
interpolation_setup to download precomputed weights for LLC90 or LLC270#220seamanticscience wants to merge 5 commits intoJuliaClimate:masterfrom
Conversation
…asets` and `DataDeps`
…ted weights for LLC90 or LLC270
…d and compute default 2° lat-lon weights)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 87.75% 87.80% +0.04%
==========================================
Files 37 37
Lines 3398 3410 +12
==========================================
+ Hits 2982 2994 +12
Misses 416 416 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a method to
interpolation_setup, which allows down/loading of precomputed interpolation weights based on theGridSpec(i.e. either 0.5° for ID=:LLC90 or 0.25° for ID=:LLC270).This could be expanded to other model grids (for example
ID=:CS32), but currently supplying an unrecognized gcmgrid falls back on calculating interpolation weights on the default 2° grid.All other behavior is the same, including interpolation_setup with no arguments, and interpolation_setup with a path to saved JLD2 weight file.